[PATCH] D92904: [lld-macho] Don't attempt to emit rebase opcodes for debug sections

[Thorsten via Phabricator via llvm-commits]

tschuett added inline comments.


================
Comment at: lld/MachO/Dwarf.cpp:24
+  for (InputSection *isec : obj->debugSections) {
+    if (StringRef *s = StringSwitch<StringRef *>(isec->name)
+                           .Case("__debug_info", &dObj->infoSection.Data)
----------------
thakis wrote:
> I would find a comment here helpful why these are the `isDebugSection` sections that get a DwarfObject. It's not obvious to me why `__debug_line` and `__debug_ranges` aren't listed here (or why we do any filtering at all). I don't know much debug information and I can believe that it's obvious to domain experts :)
llvm does not provide a isDwarfSection function?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92904/new/

https://reviews.llvm.org/D92904