[PATCH] D92645: [X86] Add X86ISD::SUBV_BROADCAST_LOAD and begin removing X86ISD::SUBV_BROADCAST (PR38969)

[Pengfei Wang via Phabricator via llvm-commits]

pengfei added a comment.

The changes on the tests look good to me. But I'm not sure the changes on the code. I'd like to see opinions from other reviewers.



================
Comment at: llvm/test/CodeGen/X86/vector-trunc.ll:119
 ; AVX2-FAST:       # %bb.0: # %entry
-; AVX2-FAST-NEXT:    vmovaps {{.*#+}} xmm2 = [1,3,5,7]
+; AVX2-FAST-NEXT:    vbroadcastf128 {{.*#+}} ymm2 = [1,3,5,7,1,3,5,7]
+; AVX2-FAST-NEXT:    # ymm2 = mem[0,1,0,1]
----------------
Seems vmovaps better here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92645/new/

https://reviews.llvm.org/D92645