[PATCH] D90836: [ARM][MachineOutliner] Add stack fixup feature.

[Yvan Roux via Phabricator via llvm-commits]

yroux abandoned this revision.
yroux added a comment.

Hi Sam,

I've split this patch into these two revisions:
https://reviews.llvm.org/D92933
https://reviews.llvm.org/D92934

Hope it will be more digest ;)
Thanks



================
Comment at: llvm/lib/Target/ARM/ARMBaseInstrInfo.cpp:5883
+  // If SP is not the base register we can't do much
+  if (SPIdx != 1) {
+    if (AddrMode != ARMII::AddrModeT2_i8s4)
----------------
samparker wrote:
> nit: Perform all the SPIdx check together?
I refactored this code in the new version


================
Comment at: llvm/lib/Target/ARM/ARMBaseInstrInfo.cpp:6212
+  for (MachineInstr &MI : MBB) {
+    if (!MI.mayLoadOrStore())
+      continue;
----------------
samparker wrote:
> There isn't this check in the first pass, so could we be missing some instructions here?
I don't think we miss anything, but this is indeed not needed, and I've removed it in the new version 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90836/new/

https://reviews.llvm.org/D90836