[PATCH] D88385: [TableGen][M68K] (Patch 1/8) Utilities for complex instruction addressing modes: CodeBeads and logical operand helper functions

Renato Golin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 9 04:31:18 PST 2020


rengolin added a comment.

In D88385#2442226 <https://reviews.llvm.org/D88385#2442226>, @RKSimon wrote:

> Does anyone have any more comments? Otherwise I think we can provisionally accept this.

LGTM too, thanks!

@jrtc27, you have marked as blocked. Have all your issues been resolved?

> @rengolin I think you wanted to see the entire patch series to be accepted before anything gets committed?

Definitely. We need to make sure the whole series is sound, then wait a bit to make sure no one else has any concern, then all patches can be committed one after another.

Feel free to mark any patch of the series as accepted, so that we can speed up the convergence.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88385/new/

https://reviews.llvm.org/D88385



More information about the llvm-commits mailing list