[PATCH] D91174: [Support] Introduce a new InstructionCost class

David Sherwood via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 9 01:34:49 PST 2020


david-arm marked an inline comment as done.
david-arm added inline comments.


================
Comment at: llvm/unittests/Support/InstructionCostTest.cpp:40
+  EXPECT_EQ(VSix / VThree, 2);
+
+  EXPECT_FALSE(IThreeA.isValid());
----------------
ctetreau wrote:
> should add tests for the increments and decrements. Would also confirm or deny my issue with the postfix increments.
I added new increment, decrement tests below and they seem to work. Thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91174/new/

https://reviews.llvm.org/D91174



More information about the llvm-commits mailing list