[PATCH] D88391: [M68k] (Patch 5/8) Target lowering

Tue Dec 8 23:46:38 PST 2020

zixuan-wu added a comment.

In D88391#2406902 <https://reviews.llvm.org/D88391#2406902>, @myhsu wrote:

>> It would be so nice if we could start all new targets with support for Global ISel instead...
>
> Yeah GlobalISel is definitely in our backlog/TODOs :-) And I think @RKSimon is right, GlobalISel doesn't support big-endian at this time point.

Hmm, I am just curious about that whether GlobalISEL is mature enough to use as default instruction selection method without implementing SelectionDAG. As a newer backend, I really would like to drop legacy stuff at start if it works.

================
Comment at: llvm/lib/Target/M68k/M68k.h:27
+/// instruction scheduling.
+FunctionPass *createM68kISelDag(M68kTargetMachine &TM);
+
----------------
rengolin wrote:
> RKSimon wrote:
> > rengolin wrote:
> > > It would be so nice if we could start all new targets with support for Global ISel instead... 
> > > 
> > > Oh well, Long live SelectionDAG! :)
> > Does GlobalISel support big-endian targets?
> Don't know. It was just a tongue-in-cheek comment. :)
> It would be so nice if we could start all new targets with support for Global ISel instead... 
> 
> Oh well, Long live SelectionDAG! :)

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88391/new/

https://reviews.llvm.org/D88391