[PATCH] D91474: [buildbot] Fix worker for ThinLTO whole program devirtualization

[Galina via Phabricator via llvm-commits]

gkistanova accepted this revision.
gkistanova added a comment.
This revision is now accepted and ready to land.

Hi Teresa,

LGTM with a nit pick. Please see my comment inline.

> if there is a way to test the LTO builder change?

Once the patch is ready we will apply it to the staging. Then you could test it by moving your bot there.



================
Comment at: zorg/buildbot/builders/ClangLTOBuilder.py:265
     # TODO: assert extra_configure_args.
-    install_prefix_specified = any(a.startswith('-DCMAKE_INSTALL_PREFIX=') for a in extra_configure_args)
+    install_prefix_specified = any(a.startswith('-DCMAKE_INSTALL_PREFIX=') for a in extra_configure_args) or any(a.startswith('-DCMAKE_INSTALL_PREFIX=') for a in extra_configure_args_lto_stage)
     assert not install_prefix_specified, "Please do not explicitly specify the install prefix for multi-stage build."
----------------
Could you make this a multi-line statement, please? It is quite long.


Repository:
  rZORG LLVM Github Zorg

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91474/new/

https://reviews.llvm.org/D91474