[PATCH] D92398: [AIX][XCOFF] emit traceback table for function in aix

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast added inline comments.


================
Comment at: llvm/lib/BinaryFormat/XCOFF.cpp:139-141
+  assert(I == ParmsNum &&
+         "The total parameters number of fixed-point or floating-point "
+         "parameters not equal to the number in the parameter type!");
----------------
The message text here is wrong. The correct `ParmsNum` here needs to include the number of vector parameters, which the XL compilers consider as neither "fixed-point" nor floating-point.

@DiggerLin, please confirm that the caller of this function correctly includes the vector parameter count.

Also, same comment as above re: `assert`.


================
Comment at: llvm/lib/BinaryFormat/XCOFF.cpp:165
+  }
+  return ParmsType;
+}
----------------
Would a `Value == 0u` check here make sense? The other function has a check that serves a similar purpose.


================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:1758
+  std::string CommentString;
+  raw_string_ostream CommentOS(CommentString);
+
----------------
I don't think a `std::string` in needed here; using `raw_svector_ostream` should work.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92398/new/

https://reviews.llvm.org/D92398