[PATCH] D85788: [Clang test] Update to allow passing extra default clang arguments in use_clang

Evgenii Stepanov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 8 16:20:10 PST 2020


eugenis added a comment.

> simply naming it as %clang_noundef would be clearer,

Hmm, yeah, that's a little better.

> This new substitution is going to be used for the noundef checks in D81678 <https://reviews.llvm.org/D81678> only anyway.

I'm not sure what you mean by this. The substitution is used ~380 times in this patch alone.
In the future, any attempt to use %clang -### or -%clang -cc1as will produce the same unused argument warning, and it is very unclear that is can be fixed with %clang_bin. Note that code search for "-disable-noundef-analysis" does NOT lead you to the definition of %clang_bin!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85788/new/

https://reviews.llvm.org/D85788



More information about the llvm-commits mailing list