[PATCH] D91174: [Support] Introduce a new InstructionCost class

Christopher Tetreault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 8 15:11:06 PST 2020


ctetreau added a comment.

I think this is pretty much fine. Please add the increment and decrement tests and this looks good to me.



================
Comment at: llvm/unittests/Support/InstructionCostTest.cpp:40
+  EXPECT_EQ(VSix / VThree, 2);
+
+  EXPECT_FALSE(IThreeA.isValid());
----------------
should add tests for the increments and decrements. Would also confirm or deny my issue with the postfix increments.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91174/new/

https://reviews.llvm.org/D91174



More information about the llvm-commits mailing list