[PATCH] D92882: [MBP] Prevent rotating a chain contains entry block

Snehasish Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 8 14:35:49 PST 2020


snehasish added a comment.

Can we add a test for this?



================
Comment at: llvm/lib/CodeGen/MachineBlockPlacement.cpp:2392
+  // The entry block should always be the first BB in a function.
+  if (ChainHeaderBB == &F->front())
+    return;
----------------
Consider using the helper MachineBasicBlock::isEntryBlock here and above.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92882/new/

https://reviews.llvm.org/D92882



More information about the llvm-commits mailing list