[PATCH] D92766: [XCOFF][AIX] Emit EH information in traceback table

[Jason Liu via Phabricator via llvm-commits]

jasonliu added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/AIXException.cpp:73
+  const Function *Per =
+      dyn_cast<Function>(F.getPersonalityFn()->stripPointerCasts());
   const MCSymbol *PerSym = Asm->TM.getSymbol(Per);
----------------
DiggerLin wrote:
> Constant *Function::getPersonalityFn() const {
>   assert(hasPersonalityFn() && getNumOperands());
>   return cast<Constant>(Op<0>());
> }
> 
> do we need the 
> assert(F.hasPersonalityFn() &&
>          "Landingpads are presented, but no personality routine is found."); 
> once more ?
It helps to tell exactly what went wrong in this context. i.e. landingpad presents, but no personality routine gets us here.
But if you think it's really redundant, I could remove it. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92766/new/

https://reviews.llvm.org/D92766