[PATCH] D92796: Pin -loop-reduce to legacy PM

Tue Dec 8 13:24:41 PST 2020

aeubanks added a comment.

In D92796#2441005 <https://reviews.llvm.org/D92796#2441005>, @asbirlea wrote:

> In D92796#2440988 <https://reviews.llvm.org/D92796#2440988>, @aeubanks wrote:
>
>> Currently LSR is not tested with the NPM in any circumstance.
>> There are no tests with `-passes=loop-reduce`, and LSR is only used in the codegen pass manager, so even with `-DEXPERIMENTAL_NEW_PASS_MANAGER=ON`, it's never in a NPM context.
>
> Exactly! But it's ported. So someone could add it to a pipeline anytime and chaos would ensue, that's what I meant :-). There may be out-of-tree usages or tests that are broken.

Oh I see. Weird that it's ported but there are no tests for it.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92796/new/

https://reviews.llvm.org/D92796