[PATCH] D91345: [AArch64] Fix rottype use in complex instr defs.

Tue Dec 8 13:09:22 PST 2020

fhahn added a comment.

In D91345#2393191 <https://reviews.llvm.org/D91345#2393191>, @dmgreen wrote:

> Like I said on the other review, sometimes reviews can be split up too much into things that are not even testable.

Agreed, this is probably why it was broken in the first place. I have patches on top of this one, which actually instantiate the pattern and work as expected. Unfortunately they will need a bit more discussing, so I think it's best to get this in independently.

> This look simple enough on it's own though. LGTM

Thank you very much for taking a look!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91345/new/

https://reviews.llvm.org/D91345