[PATCH] D92120: [flang][openacc] Update reference to OpenACC 3.1 specification

Valentin Clement via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 8 11:35:49 PST 2020


clementval added inline comments.


================
Comment at: flang/lib/Semantics/check-acc-structure.cpp:149
-    // Restriction - 1962 -> (843-844) (PARALLEL LOOP)
-    CheckOnlyAllowedAfter(llvm::acc::Clause::ACCC_device_type,
-        {llvm::acc::Clause::ACCC_async, llvm::acc::Clause::ACCC_wait,
----------------
clementval wrote:
> SouraVX wrote:
> > Please help me understand this:
> > This is a code change right ? Just curious, are there any test case modifications supporting this ? 
> > Or is it just code refactoring ?
> From 3.1 the `serial` construct takes the same restriction as the `parallel` and `kernels` for the supported clauses after `device_type`. There was already couple of tests in this sense but I can surely add some more. 
In fact the test are there already. The restriction has been simplified in 3.1 so it can be checked the same way for `parallel`, `serial` and  `kernels`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92120/new/

https://reviews.llvm.org/D92120



More information about the llvm-commits mailing list