[PATCH] D92766: [XCOFF][AIX] Emit EH information in traceback table

[David Tenty via Phabricator via llvm-commits]

daltenty added inline comments.


================
Comment at: llvm/include/llvm/BinaryFormat/XCOFF.h:404
   TB_OS2 = 0x10,         ///< Reserved for OS use
+  TB_EH_INFO = 0x08,     ///< Exception handling info presents.
   TB_LONGTBTABLE2 = 0x01 ///< Additional tbtable extension exists
----------------
nit: since every other entry is missing a period, lets just omit it (and the s)


================
Comment at: llvm/lib/CodeGen/AsmPrinter/AIXException.cpp:71
+  const Function *Per =
+      dyn_cast<Function>(F.getPersonalityFn()->stripPointerCasts());
   const MCSymbol *PerSym = Asm->TM.getSymbol(Per);
----------------
Compared with what was here before it seems like `F.getPersonalityFn()` can assert if `hasPersonalityFn()` is false, which can happen now because we won't check that before setting Per anymore, and we'll answer ShouldEmitEHBlock true if we have landing pads regardless of the personality setting. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92766/new/

https://reviews.llvm.org/D92766