[PATCH] D92533: [flang][openacc] Add missing loop construct restriction and validity tests

Valentin Clement via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 8 08:05:57 PST 2020


clementval marked an inline comment as done.
clementval added inline comments.


================
Comment at: flang/lib/Semantics/canonicalize-acc.cpp:99
+    for (const auto &clause : accClauseList.v) {
+      if (std::holds_alternative<parser::AccClause::Collapse>(&clause.u) ||
+          std::holds_alternative<parser::AccClause::Tile>(&clause.u)) {
----------------
sameeranjoshi wrote:
> Please check syntax this doesn't build.
> no `&`.
Thanks for catching this. Don't know what I did with this :-)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92533/new/

https://reviews.llvm.org/D92533



More information about the llvm-commits mailing list