[PATCH] D92120: [flang][openacc] Update reference to OpenACC 3.1 specification
Sourabh Singh Tomar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Dec 8 07:28:37 PST 2020
SouraVX added inline comments.
================
Comment at: flang/lib/Semantics/check-acc-structure.cpp:81
case llvm::acc::Directive::ACCD_serial:
- // Restriction - 919
+ // Restriction - line 1004-1005
CheckOnlyAllowedAfter(llvm::acc::Clause::ACCC_device_type,
----------------
No strong opinion here(on line number part), however in `openmp` semantics they mention section number and some description https://github.com/llvm/llvm-project/blob/main/flang/lib/Semantics/check-omp-structure.cpp#L74 having said that, that is also confusing since it doesn't mention that sections belongs to openmp4.5 or openmp5.0 or openmp5.1?
Here atleast that part is clear all line number reference here refer to openacc3.1
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92120/new/
https://reviews.llvm.org/D92120
More information about the llvm-commits
mailing list