[PATCH] D92533: [flang][openacc] Add missing loop construct restriction and validity tests

sameeran joshi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 8 07:10:39 PST 2020


sameeranjoshi accepted this revision.
sameeranjoshi added a comment.
This revision is now accepted and ready to land.

Thanks for clarifications.
Approving it just take care of the build issue before merging.
LGTM.



================
Comment at: flang/lib/Semantics/canonicalize-acc.cpp:99
+    for (const auto &clause : accClauseList.v) {
+      if (std::holds_alternative<parser::AccClause::Collapse>(&clause.u) ||
+          std::holds_alternative<parser::AccClause::Tile>(&clause.u)) {
----------------
Please check syntax this doesn't build.
no `&`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92533/new/

https://reviews.llvm.org/D92533



More information about the llvm-commits mailing list