[PATCH] D91870: [WebAssembly] Add support for table linking to wasm-ld

[Andy Wingo via Phabricator via llvm-commits]

wingo marked an inline comment as done.
wingo added a comment.

In D91870#2426358 <https://reviews.llvm.org/D91870#2426358>, @sbc100 wrote:

> Maybe there are two logical parts we can separate here:
>
> 1. Support for first class tables in input files
>
> 2. Support for the special `__indirect_function_table`
>
> I guess they are somewhat intertwined by I can imagine landing (1) without changing the way we handle the special table 0.    Maybe its not worth the work to split up?

For what it is worth, this was the first tack that I took, but I couldn't find a useful intermediate point where we still had consistent files.  Simple things like whether __indirect_function_table is imported, exported, or neither end up propagating into special cases all over the place -- at least that was my conclusion at the time and I think it might still hold.  It seemed cleaner to me to make something more conventional using symbols and relocs like everything else in the linker, and then adapt the current input files to that newer more conventional machinery.  Dunno.  WDYT?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91870/new/

https://reviews.llvm.org/D91870