[PATCH] D92837: [X86] Support tilezero intrinsic and c interface for AMX.

[LuoYuanke via Phabricator via llvm-commits]

LuoYuanke added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ExpandPseudo.cpp:499
+    MI.RemoveOperand(3); // Remove $tmmcfg
+    for (int i = 2; i > 0; --i)
+      MI.RemoveOperand(i);
----------------
pengfei wrote:
> Can change to i = 3?
Yes, then remove line 498.


================
Comment at: llvm/lib/Target/X86/X86ISelDAGToDAG.cpp:4624
+      SDValue Chain = Node->getOperand(0);
+      SDValue Ops[] = {Node->getOperand(2), Node->getOperand(3), CFG, Chain};
+      MachineSDNode *CNode =
----------------
pengfei wrote:
> Why tilezero needs chain?
I didn't declare "IntrNoMem" in "include/llvm/IR/IntrinsicsX86.td". I can revise the code to declare "IntrNoMem".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92837/new/

https://reviews.llvm.org/D92837