[PATCH] D92813: [RISCV] Share VTYPE encoding code between the assembler and the CustomInserter for adding VSETVLI before vector instructions
Fraser Cormack via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Dec 8 01:38:58 PST 2020
frasercrmck added a comment.
I had actually prototyped something very similar so I'm all for this.
================
Comment at: llvm/lib/Target/RISCV/Utils/RISCVBaseInfo.h:363
+inline static unsigned encodeVTYPE(RISCVVLMUL VLMUL, RISCVVSEW VSEW,
+ bool TailAgnostic, bool MaskedoffAgnostic) {
----------------
I think that it would help to be explicit (in a comment) that this operand encoding is the same as the vtype binary encoding and is assumed to be so in the MC layers.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92813/new/
https://reviews.llvm.org/D92813
More information about the llvm-commits
mailing list