[PATCH] D92706: [coroutine] should disable inline before calling coro split
JunMa via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Dec 8 00:13:26 PST 2020
junparser accepted this revision.
junparser added a comment.
This revision is now accepted and ready to land.
hi @lxfind, sorry for the late reply. After D85812 <https://reviews.llvm.org/D85812>, we think it might be better to move both of attribute and intrinsic of coroutine into core library, however such changes are too heavy to do.
The reason I suggest adding the attribute into EnumAttr is that i believe that we may need to use presplit attribute in other places (such as lower debug intrinsic. ) and we do not want to write the string anywhere cross different parts. Add API in Function will reduce the impact, so LGTM, thanks for the patch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92706/new/
https://reviews.llvm.org/D92706
More information about the llvm-commits
mailing list