[PATCH] D91048: [AMDGPU] Add new pseudos for indirect addressing with VGPR Indexing
Stanislav Mekhanoshin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Dec 7 20:41:50 PST 2020
rampitec added a comment.
In D91048#2438775 <https://reviews.llvm.org/D91048#2438775>, @kerbowa wrote:
> In D91048#2438757 <https://reviews.llvm.org/D91048#2438757>, @rampitec wrote:
>
>> JBTW, having a need to def M0 probably defeats the idea of potential rescheduling which justifies the separation of the indirect access methods.
>
> The GPR_IDX variants are where we are speaking of adding the def M0 right? These are not expanded until after the scheduler. The MOVREL version's M0 def is expanded earlier during ISel finalization.
>
> My thinking was that we wanted rescheduling the M0 def with the MOVREL version but not the GPR_IDX version and that combining these methods wouldn't allow that.
OK, but def is still seems to be needed. We also need Matt to clrify MODE question.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91048/new/
https://reviews.llvm.org/D91048
More information about the llvm-commits
mailing list