[PATCH] D92436: [Time-report] Add a flag -ftime-report={per-pass,per-pass-run} to control the pass timing aggregation

[Yuanfang Chen via Phabricator via llvm-commits]

ychen added inline comments.


================
Comment at: llvm/lib/IR/PassTimingInfo.cpp:47
+    cl::desc("Time each pass run, printing elapsed time for each run on exit"),
+    cl::callback([](const bool &) { TimePassesIsEnabled = true; }));
+
----------------
aeubanks wrote:
> is this necessary?
Yeah, it is. `TimePassesPerRun` (corresponding to TimePassesHandler::PerRun) is not used if `TimePassesIsEnabled` is false.


================
Comment at: llvm/test/Other/time-passes.ll:55
 ; TIME-NEW-DAG:      TargetLibraryAnalysis
+; TIME-NEW-PER-PASS-DAG:   InstCombinePass
+; TIME-NEW-PER-PASS-DAG:   LICMPass
----------------
aeubanks wrote:
> check that this doesn't appear multiple times under TIME-NEW-PER-PASS?
This is important. Thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92436/new/

https://reviews.llvm.org/D92436