[PATCH] D91487: [AMDGPU] Don't require swz operand for non-return Atomics.
Stanislav Mekhanoshin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Dec 7 15:31:28 PST 2020
rampitec added a comment.
In D91487#2421897 <https://reviews.llvm.org/D91487#2421897>, @MJDSys wrote:
> In D91487#2397822 <https://reviews.llvm.org/D91487#2397822>, @rampitec wrote:
>
>> Needs test.
>
> Hi @rampitec,
>
> I've tried writing a test for this change, but I've been having trouble (I'm new to LLVM so I might be missing the obvious answer). From what I can see, I thought the correct option would be to create a MIR test, using the same instruction that I saw when investigating the original problem. I started by copying and modifying an existing test in fix-sgpr-copies.mir:
legalizeOperands() works as a part of the instruction selection so you cannot use mir test anyway. You need to write an .ll test (presumably calling an intrinsic to emit this atomic). You can start with code from llvm.amdgcn.buffer.atomic.ll.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91487/new/
https://reviews.llvm.org/D91487
More information about the llvm-commits
mailing list