[PATCH] D92766: [XCOFF][AIX] Emit EH information in traceback table

Mon Dec 7 14:53:47 PST 2020

DiggerLin added inline comments.

================
Comment at: llvm/lib/BinaryFormat/XCOFF.cpp:151

+SmallString<32> XCOFF::getExtendedTBTableFlagString(uint8_t Flag) {
+  SmallString<32> Res;
----------------
there already have a function define getExtendedTBTableFlagString  in the  https://reviews.llvm.org/D92398

================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:1994
+    if (ShouldEmitEHBlock)
+      ExtensionTableFlag |= ExtendedTBTableFlag::TB_EH_INFO;
+
----------------
since we only have ShouldEmitEHBlock.  if the ShouldEmitEHBlock is false,  it will still output an ExtensionTableFlag. Add an assert(ShouldEmitEHBlock) here ?

================
Comment at: llvm/test/CodeGen/PowerPC/aix-exception.ll:2
 ; RUN: llc -verify-machineinstrs -mtriple powerpc-ibm-aix-xcoff -mcpu=pwr4 \
-; RUN:     -mattr=-altivec < %s | \
+; RUN:     -mattr=-altivec -xcoff-traceback-table < %s | \
 ; RUN:   FileCheck --check-prefixes=ASM,ASM32 %s
----------------
we can delete -xcoff-traceback-table here after rebased on the latest https://reviews.llvm.org/D92398

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92766/new/

https://reviews.llvm.org/D92766