[PATCH] D92695: [X86ISelLowering] don't emit frame pointers for eflags intrinsics.
Reid Kleckner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Dec 7 13:49:00 PST 2020
rnk added inline comments.
================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:25976
- MachineFrameInfo &MFI = DAG.getMachineFunction().getFrameInfo();
- MFI.setHasCopyImplyingStackAdjustment(true);
// Don't do anything here, we will expand these intrinsics out later
----------------
This is the only writer of HasCopyImplyingStackAdjustment, so if we did go ahead with this, I'd ask you to clean up the readers.
================
Comment at: llvm/test/CodeGen/X86/win64_frame.ll:194
-; CHECK-NEXT: movq %rsp, %rbp
-; CHECK-NEXT: .seh_setframe %rbp, 0
-; CHECK-NEXT: .seh_endprologue
----------------
>From a Windows PoV, this test case needs to remain unchanged, otherwise we break the contract that stack unwinding works at every PC.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92695/new/
https://reviews.llvm.org/D92695
More information about the llvm-commits
mailing list