[PATCH] D92783: [flang] Improve initializer semantics, esp. for component default values

[Peter Klausler via Phabricator via llvm-commits]

klausler created this revision.
klausler added a reviewer: tskeith.
klausler added a project: Flang.
Herald added a subscriber: jdoerfert.
Herald added a reviewer: sscalpone.
klausler requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

This patch plugs many holes in static initializer semantics, improves error
messages for default initial values and other component properties in
parameterized derived type instantiations, and cleans up several small
issues noticed during development.  We now do proper scalar expansion,
folding, and type, rank, and shape conformance checking for component
default initializers in derived types and PDT instantiations.
The initial values of named constants are now guaranteed to have been folded
when installed in the symbol table, and are no longer folded or
scalar-expanded at each use in expression folding.  Semantics documentation
was extended with information about the various kinds of initializations
in Fortran and when each of them are processed in the compiler.

Some necessary concomitant changes have bulked this patch out a bit:

- contextual messages attachments, which are now produced for parameterized derived type instantiations so that the user can figure out which instance caused a problem with a component, have been added as part of ContextualMessages, and their implementation was debugged
- several APIs in evaluate::characteristics was changed so that a FoldingContext is passed as an argument rather than just its intrinsic procedure table; this affected client call sites in many files
- new tools in Evaluate/check-expression.cpp to determine when an Expr actually is a single constant value and to validate a non-pointer variable initializer or object component default value
- shape conformance checking has additional arguments that control whether scalar expansion is allowed
- several now-unused functions and data members noticed and removed
- several crashes and bogus errors exposed by testing this new code were fixed
- a -fdebug-stack-trace option to enable LLVM's stack tracing on a crash, which might be useful in the future

TL;DR: Initialization processing does more and takes place at the right
times for all of the various kinds of things that can be initialized.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D92783

Files:
  flang/docs/Semantics.md
  flang/include/flang/Common/reference-counted.h
  flang/include/flang/Evaluate/characteristics.h
  flang/include/flang/Evaluate/check-expression.h
  flang/include/flang/Evaluate/common.h
  flang/include/flang/Evaluate/shape.h
  flang/include/flang/Evaluate/tools.h
  flang/include/flang/Evaluate/type.h
  flang/include/flang/Parser/message.h
  flang/include/flang/Semantics/scope.h
  flang/include/flang/Semantics/symbol.h
  flang/include/flang/Semantics/tools.h
  flang/lib/Evaluate/characteristics.cpp
  flang/lib/Evaluate/check-expression.cpp
  flang/lib/Evaluate/fold-implementation.h
  flang/lib/Evaluate/fold-logical.cpp
  flang/lib/Evaluate/fold.cpp
  flang/lib/Evaluate/intrinsics.cpp
  flang/lib/Evaluate/shape.cpp
  flang/lib/Evaluate/tools.cpp
  flang/lib/Evaluate/type.cpp
  flang/lib/Parser/message.cpp
  flang/lib/Parser/parse-tree.cpp
  flang/lib/Semantics/check-call.cpp
  flang/lib/Semantics/check-declarations.cpp
  flang/lib/Semantics/check-declarations.h
  flang/lib/Semantics/check-do-forall.cpp
  flang/lib/Semantics/data-to-inits.cpp
  flang/lib/Semantics/expression.cpp
  flang/lib/Semantics/pointer-assignment.cpp
  flang/lib/Semantics/resolve-names.cpp
  flang/lib/Semantics/tools.cpp
  flang/lib/Semantics/type.cpp
  flang/test/Semantics/array-constr-values.f90
  flang/test/Semantics/data04.f90
  flang/test/Semantics/init01.f90
  flang/test/Semantics/resolve37.f90
  flang/test/Semantics/resolve44.f90
  flang/test/Semantics/resolve58.f90
  flang/test/Semantics/resolve69.f90
  flang/test/Semantics/structconst02.f90
  flang/tools/f18/f18.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D92783.309993.patch
Type: text/x-patch
Size: 116752 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201207/66db9a91/attachment-0001.bin>