[PATCH] D92657: Fix interaction between clang and some inline builtins from glibc under _FORTIFY_SOURCE
serge via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Dec 7 12:27:36 PST 2020
serge-sans-paille marked an inline comment as done.
serge-sans-paille added inline comments.
================
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2984-2986
+ std::unique_ptr<CFG> cfg =
+ CFG::buildCFG(FD, Body, &Context, CFG::BuildOptions());
+ ParentMap PM(Body);
----------------
rnk wrote:
> These are both really expensive. Is this really necessary?
I'd be very happy to remove them. I could remove these use by designing an ad-hoc analysis to detect basic always recursive functions patterns (basically some kind of CFG-like analysis that would build the CFG on the fly with early branch exit when it finds a call to self)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92657/new/
https://reviews.llvm.org/D92657
More information about the llvm-commits
mailing list