[PATCH] D92736: [lld/mac] Use xxhash instead of MD5 for computing the UUID

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 7 11:52:51 PST 2020


thakis added a comment.

In D92736#2437447 <https://reviews.llvm.org/D92736#2437447>, @MaskRay wrote:

> xxhash is a pretty arbitrary choice (https://bugs.llvm.org/show_bug.cgi?id=37029). If there are a better one, we can use that, too.

Sure. But for now it's what the other ports use, so for now let's go with this :) (...assuming lldb can handle it.)

If md5 is important for some other apple-internal tool, I guess we can add a flag for picking the hash style, like ELF has.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92736/new/

https://reviews.llvm.org/D92736



More information about the llvm-commits mailing list