[PATCH] D50010: [VNCoercion] Disallow coercion between different ni addrspaces

[Philip Reames via Phabricator via llvm-commits]

reames accepted this revision.
reames added a comment.
This revision is now accepted and ready to land.

LGTM.

As a side note, I don't think you actually need to disallow conversion of the null pointer between two different NI address spaces.  If you wanted to improve opt quality, folding your check into the previous one would be beneficial.  I'm not going to require that as this a) fixes a correctness bug, and b) has been outstanding for way to long.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D50010/new/

https://reviews.llvm.org/D50010