[PATCH] D92668: [SLP]Merge reorder and reuse shuffles.

Alexey Bataev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 7 06:41:27 PST 2020


ABataev added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:3510
         }
       }
       int DeadCost = ReuseShuffleCost;
----------------
anton-afanasyev wrote:
> ABataev wrote:
> > anton-afanasyev wrote:
> > > 
> > I don't get it. What do you want to see here?
> I suggest to join code below (starting from `if (!NeedToShuffleReuses && !E->ReorderIndices.empty())`) to this if-block:
> ```
> if (NeedToShuffleReuses) {
>   ...
>   DeadCost = ReuseShuffleCost;
> } else if (!E->ReorderIndices.empty()) {
>   DeadCost = TTI->getShuffleCost(TargetTransformInfo::SK_PermuteSingleSrc, VecTy);
> }
> ```
> 
Ok, I see


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92668/new/

https://reviews.llvm.org/D92668



More information about the llvm-commits mailing list