[PATCH] D90046: [LiveDebugValues] Handle spill locations with a fixed and scalable component.

[Djordje Todorovic via Phabricator via llvm-commits]

djtodoro added a comment.

Thanks for addressing the comments.



================
Comment at: llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.cpp:231
   bool operator<(const SpillLoc &Other) const {
-    return std::tie(SpillBase, SpillOffset) <
-           std::tie(Other.SpillBase, Other.SpillOffset);
+    return std::make_tuple(SpillBase, SpillOffset.getFixed(),
+                    SpillOffset.getScalable()) <
----------------
We use tuples here because `std::tie()` takes l-values only?


================
Comment at: llvm/lib/CodeGen/LiveDebugValues/VarLocBasedImpl.cpp:553
+      case SpillLocKind:
+        return Loc.SpillLocation == Other.Loc.SpillLocation;
+      case RegisterKind:
----------------
Do we use `Loc.Hash` for the case of Spill locations?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90046/new/

https://reviews.llvm.org/D90046