[PATCH] D92734: [lld/mac] Make X86_64::getImplicitAddend not do heap allocations

Mon Dec 7 06:03:55 PST 2020

thakis added a comment.

Thanks!

In D92734#2436805 <https://reviews.llvm.org/D92734#2436805>, @int3 wrote:

> oh wow... I'd have thought that compilers would be better at optimizing such a common operation

The compiler would have to inline validateLength() to do that, and it's called a few times and has a large-ish loop at the bottom. A common technique is to manually outline the cold part of a function, and then the compiler can inline the hot part and that might be enough to let the compiler optimize this (...but I haven't checked).

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92734/new/

https://reviews.llvm.org/D92734