[PATCH] D92737: [X86] Handle localdynamic TLS model in x32 mode

[Pengfei Wang via Phabricator via llvm-commits]

pengfei added inline comments.


================
Comment at: llvm/test/CodeGen/X86/pic.ll:322
+
+define void @test10() nounwind {
+entry:
----------------
hvdijk wrote:
> pengfei wrote:
> > What're this and test11 testing for? It seems you only changed for LocalDynamic model in this patch.
> That is correct, I did not update anything for the InitialExec and LocalExec TLS models. I added these tests not because this diff fixes bugs in them, but because like LocalDynamic, these models were also not covered by existing tests. Despite the title (I wrote the title and description afterwards), the goal of this diff was not specifically to make sure that the LocalDynamic TLS model is working, but that all TLS models are working. For this, I first made sure that all TLS models are tested, and then fixed the code generation where needed, which turned out to only be that of the LocalDynamic model.
Thanks Harald, I just saw you had mentioned it in the summary. Sorry for the noise.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92737/new/

https://reviews.llvm.org/D92737