[PATCH] D92013: [DebugInfo] Don't use DW_OP_implicit_value for fragments

Mon Dec 7 03:38:59 PST 2020

jmorse added a comment.

I'd like to chime in and point out a slightly related scenario [0] where we have to interpret a DIExpression to work out how adding operators is going to change the meaning of the expression. I believe in the long run we need metadata describing "the attributes of this variable location" rather than packing information into DIExpressions and having to interpret it.

For the record this patch looks fine, but DWARF printing is outside of my comfort zone so I'd prefer to hear from others.

[0] https://github.com/llvm/llvm-project/blob/7b1cb4715063679531e51127eee869cd03df88da/llvm/lib/CodeGen/PrologEpilogInserter.cpp#L1221

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92013/new/

https://reviews.llvm.org/D92013