[PATCH] D92644: [obj2yaml] - Support dumping objects that have multiple SHT_SYMTAB_SHNDX sections.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 7 02:42:18 PST 2020


grimar added inline comments.


================
Comment at: llvm/tools/obj2yaml/elf2yaml.cpp:326
+      } else {
+        return createStringError(errc::not_supported,
+                                 "unable to read extended section indexes: " +
----------------
jhenderson wrote:
> Is `not_supported` correct here? I'm asuming the error is when the data isn't a valid `getSHNDXTable` which sounds more like `parse_failed` or `illegal_argument`.
Right. Done.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92644/new/

https://reviews.llvm.org/D92644



More information about the llvm-commits mailing list