[PATCH] D92052: [MC][ELF] Accept abbreviated form with sh_flags and sh_entsize

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 7 01:37:24 PST 2020


jhenderson added inline comments.


================
Comment at: llvm/test/MC/ELF/section-omitted-attributes.s:3
+
+# CHECK: .section        .foo,"aM", at progbits,1
+
----------------
Is it worth adding something like this after this line:

```
CHECK-NOT: .section
CHECK-NOT: .pushsection
```
? I don't know if it's actually what happens, but it wouldn't make sense to repeat the section directives if they aren't needed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92052/new/

https://reviews.llvm.org/D92052



More information about the llvm-commits mailing list