[PATCH] D91761: [FileCheck] Add check modifier capability

Mon Dec 7 01:32:58 PST 2020

jhenderson added inline comments.

================
Comment at: llvm/test/FileCheck/check-literal.txt:3
+
+; This tests the LITERAL directive modifier.
+
----------------
Here and in other comments, I suggest using `;;` for the comment marker - the double marker helps distinguish it from an actual FileCheck or lit directive.

We have tended to do that in some newer tests in the LLVM binutils at least, and I think others I've been involved in reviewing.

================
Comment at: llvm/test/FileCheck/check-literal.txt:27-28
+
+; RUN: not FileCheck %s --input-file %s --check-prefix=CHECK-ERRNOT 2>&1 \
+; RUN: | FileCheck %s --check-prefix=ERRNOT
+
----------------
I think this needs `%ProtectFileCheckOutput`, but am not 100% sure if that applies for "not" cases (I think it does).

Also, I have a personal preference for continuation lines to be formatted as suggested in the inline edit. The idea is that it clearly shows from looking at the first line that you've got to the end of that command, whilst the second line is indented shwoing that it is a continuation.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91761/new/

https://reviews.llvm.org/D91761