[PATCH] D91703: [GISel] Teach TableGen to check predicates of immediate operands in patterns

Dominik Montada via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 7 01:11:48 PST 2020


gargaroff updated this revision to Diff 309831.
gargaroff marked 3 inline comments as done.
gargaroff added a comment.

Rebase. Group with `GIM_CheckI64ImmPredicate`. Change naming to `GIM_CheckImmOperandPredicate`.

@arsenm I went with @foad's suggestion in the end because it had less impact than trying to make the naming work with CImm and Imm. Also MachineOperand seems to use them in aslightly different meaning, unless I'm misunderstanding. Hope that's fine for you.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91703/new/

https://reviews.llvm.org/D91703

Files:
  llvm/include/llvm/CodeGen/GlobalISel/InstructionSelector.h
  llvm/include/llvm/CodeGen/GlobalISel/InstructionSelectorImpl.h
  llvm/test/TableGen/immarg-predicated.td
  llvm/utils/TableGen/GlobalISelEmitter.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D91703.309831.patch
Type: text/x-patch
Size: 7771 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201207/a4434a4d/attachment.bin>


More information about the llvm-commits mailing list