[PATCH] D92073: [CodeGen] Add text section prefix for COFF object file

Mon Dec 7 00:30:50 PST 2020

TaoPan added inline comments.

================
Comment at: llvm/test/CodeGen/X86/mingw-comdats.ll:88
+; Make sure the assembler puts the .text$hot and .text$unlikely in sections
+; with the right order.
+; SECTIONORDER: 0   .text
----------------
mstorsjo wrote:
> I'm not quite sure what this test actually is supposed to test; ordering of sections according to the suffixes doesn't happen at the object file stage, that only happens while linking.
> 
> What would be useful, though, would be to add a new function similar to the `_Z3fooi` one above, with e.g. a unlikely attribute, and check that all of .text/.xdata/.pdata get similar suffixes just like the checks right above on lines 80-83.
Thanks for your detail guidance!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92073/new/

https://reviews.llvm.org/D92073