[PATCH] D92698: Add recursive decomposition reasoning to isKnownNonEqual

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Dec 5 15:56:41 PST 2020


reames added inline comments.


================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:2502
     return false;
-  return isKnownNonZero(Op, 0, Q);
+  return isKnownNonZero(Op, Depth + 1, Q);
 }
----------------
nikic wrote:
> Should be just `Depth` here to stay consistent with the computeKnownBits case, and the previous behavior?
I don't think so.  We are recursing into an operand.  


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92698/new/

https://reviews.llvm.org/D92698



More information about the llvm-commits mailing list