[PATCH] D92722: [TableGen] [CodeGenTarget] Cache the target's instruction namespace

Sat Dec 5 10:12:52 PST 2020

dblaikie added a comment.

In D92722#2435708 <https://reviews.llvm.org/D92722#2435708>, @Paul-C-Anagnostopoulos wrote:

> I can't separate the performance increases of the two caching revisions, but I suspect the other one produces most of the improvement (https://reviews.llvm.org/D92674).
>
> At least one backend requests the namespace 22 times, and the search is linear and must skip all the TargetOpcode instructions. There are about 200 of them, I think.

Yeah, I'd expect that's pretty cheap/not a major performance consideration.

> But if you think this is pointless, I'm happy to discard it. On the other hand, it's a total of 3 new lines of code.

Up to you - no strong feelings. Your call.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92722/new/

https://reviews.llvm.org/D92722