[PATCH] D92722: [TableGen] [CodeGenTarget] Cache the target's instruction namespace
David Blaikie via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Dec 5 09:20:12 PST 2020
dblaikie added a comment.
Is there much data to suggest this is an observable performance issue? (if the number of times it's queried is small, or the number of elements it searches through is small, etc - perhaps it doesn't matter & the simpler code might be better?)
================
Comment at: llvm/utils/TableGen/CodeGenTarget.h:63
+ mutable StringRef InstNamespace = StringRef();
mutable std::vector<const CodeGenInstruction*> InstrsByEnum;
----------------
The ` = StringRef()` is redundant here and should be omitted.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92722/new/
https://reviews.llvm.org/D92722
More information about the llvm-commits
mailing list