[PATCH] D92694: [BasicAA] Fix a bug with relational reasoning across iterations

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Dec 5 02:55:13 PST 2020


nikic accepted this revision.
nikic added a comment.
This revision is now accepted and ready to land.

LGTM

Due diligence: I was a bit concerned about dropping the known bits fallback (which we can retain even in cycles). After adding some AA stats, I see:

                 | Baseline |    Patch
  aa.NumMayAlias |  4920438 |  4920375
  aa.NumNoAlias  | 27075701 | 27075764

So this actually marginally improves the AA results. Presumably that's because we can now handle the case where one of the indexes is a phi, but we're not in a cycle.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92694/new/

https://reviews.llvm.org/D92694



More information about the llvm-commits mailing list