[PATCH] D92691: [WIP] Add Object and ObjectWriter support for wasm COMDAT sections

[Derek Schuff via Phabricator via llvm-commits]

dschuff created this revision.
Herald added subscribers: sunfish, hiraditya, jgravelle-google, sbc100.
dschuff updated this revision to Diff 309653.
dschuff added a comment.
dschuff published this revision for review.
Herald added subscribers: llvm-commits, aheejin.
Herald added a project: LLVM.

Add the rest


sbc100 added a comment.

Looks great!


dschuff added a comment.

This version basically just tests -fdebug-types-section end-to-end to YAML via comdats. (It probably needs more tests, suggestions are welcome)
I'm thinking it would be good to add assembly syntax so we can test just the MC and Object stuff separately from the debuginfo stuff. Not sure if that should be a separate change?



================
Comment at: llvm/test/MC/WebAssembly/comdat-sections.ll:7
+; CHECK:     Comdats:
+; CHECK:      - Name:            '4721183873463917179'
+; CHECK:        Entries:
----------------
Where does this name come from?


  Allow sections to be placed into COMDAT groups, in addtion to functions and data
  segments.
  
  Also make section symbols unnamed, which allows sections with identical names
  (section names are independent of their section symbols, but previously we
  gave the symbols the same name as their sections, which results in collisions
  when sections are identically-named).


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D92691

Files:
  llvm/include/llvm/BinaryFormat/Wasm.h
  llvm/include/llvm/Object/Wasm.h
  llvm/lib/MC/MCContext.cpp
  llvm/lib/MC/MCObjectFileInfo.cpp
  llvm/lib/MC/WasmObjectWriter.cpp
  llvm/lib/Object/WasmObjectFile.cpp
  llvm/lib/ObjectYAML/WasmYAML.cpp
  llvm/test/DebugInfo/WebAssembly/dwarf-headers.ll
  llvm/test/MC/WebAssembly/comdat-sections.ll
  llvm/tools/obj2yaml/wasm2yaml.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D92691.309653.patch
Type: text/x-patch
Size: 9033 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201205/a8347229/attachment.bin>