[PATCH] D92695: [X86ISelLowering] don't emit frame pointers for eflags intrinsics.

Fri Dec 4 15:15:25 PST 2020

nickdesaulniers added a comment.

In D92695#2435025 <https://reviews.llvm.org/D92695#2435025>, @craig.topper wrote:

> Maybe the linux kernel disables the red zone and this isn't a problem.

The x86_64 (64b) Linux kernel is built with `-mno-red-zone`; I'm not sure if that's precisely the same as "disables the red zone."

> But I worry about others using these builtins without disabling the red zone.

Wouldn't `-fno-omit-frame-pointer` or `/Oy-` as described in this commit message prevent that?  This patch is mostly about matching GCCs behavior for these builtins, so "others using these builtins without disabling the red zone" would already be broken in such a case when built with GCC.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92695/new/

https://reviews.llvm.org/D92695