[PATCH] D92689: [scudo][standalone] Small changes to the fastpath
Peter Collingbourne via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Dec 4 14:15:05 PST 2020
pcc added inline comments.
================
Comment at: compiler-rt/lib/scudo/standalone/combined.h:1053
const bool BypassQuarantine =
- !Quarantine.getCacheSize() | !Size | (Size > QuarantineMaxChunkSize);
+ !Quarantine.getCacheSize() || ((Size - 1) > QuarantineMaxChunkSize);
if (BypassQuarantine) {
----------------
Isn't this changing the condition? i.e. it should be `Size - 1 > QuarantineMaxChunkSize - 1` now.
Does the assembly still look bad if we just have logical OR here with the original clauses?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92689/new/
https://reviews.llvm.org/D92689
More information about the llvm-commits
mailing list