[PATCH] D92398: [AIX][XCOFF] emit traceback table for function in aix

[Jason Liu via Phabricator via llvm-commits]

jasonliu added inline comments.


================
Comment at: llvm/test/CodeGen/PowerPC/aix-emit-tracebacktable.ll:107
+; COMMON-NEXT:  .byte   0x09                            # Language = C++
+; COMMON-NEXT:  .byte   0xa2                            #  +IsGlobaLinkage,-IsOutOfLineEpilogOrPrologue
+; COMMON-NEXT:                                        #  +HasTraceBackTableOffset,-IsInternalProcedure
----------------
To match the style with the llvm-objdump, we would want to print a space after `,`.


================
Comment at: llvm/test/CodeGen/PowerPC/aix-emit-tracebacktable.ll:108
+; COMMON-NEXT:  .byte   0xa2                            #  +IsGlobaLinkage,-IsOutOfLineEpilogOrPrologue
+; COMMON-NEXT:                                        #  +HasTraceBackTableOffset,-IsInternalProcedure
+; COMMON-NEXT:                                        #  -HasControlledStorage,-IsTOCless
----------------
Extra space printed after `#`.


================
Comment at: llvm/test/CodeGen/PowerPC/aix-emit-tracebacktable.ll:116
+; COMMON-NEXT:  .byte   0x00                            #  -HasExtensionTable,-HasVectorInfo,NumOfGPRsSaved = 0
+; COMMON-NEXT:  .byte   0x05                            # #NumberOfFixedParms = 5
+; COMMON-NEXT:  .byte   0x05                            # #NumberOfFPParms = 2,+HasParmsOnStack
----------------
Extra `#` here and the line below.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92398/new/

https://reviews.llvm.org/D92398